bpo-31203: Added constant socket.IP_PKTINFO by guyincognito-io · Pull Request #3161 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blurb is missing.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@AllesCoolAllesBestens, please take a look at the review request here and the comment on the bug tracker issue. Thank you!
Looks like this is stale - @csabella are we good to close?
@alimcmaster1, thanks for the ping. Yes, I'm going to close this due to inactivity. It can be reopened if the original author is interested in working on it or a new PR can be created to replace it. If a new PR is created and uses the original change, please give credit to @AllesCoolAllesBestens in the pull request message.
It looks like it's already been replaced by #20029. Thanks!
