bpo-27755: IDLE: Convert configdialog DynOptionMenu to ttk OptionMenu by csabella · Pull Request #3215 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

csabella

I know you may want to get rid of Option Menus, but I wanted to show you the ttk version. This was too much of a change to include with the first patch.

https://bugs.python.org/issue30781

@csabella

@terryjreedy

This is a definite improvement. A single OptionMenu could work for a unified list of keysets. For themes, I am thinking of a listbox, as with fonts, so one can move around to see the effect of different choices without having the box close.

@terryjreedy terryjreedy changed the titlebpo-30781: IDLE: Convert configdialog DynOptionMenu to ttk OptionMenu bpo-27755: IDLE: Convert configdialog DynOptionMenu to ttk OptionMenu

Sep 11, 2017

@terryjreedy

@terryjreedy

@terryjreedy

Why? The change is still needed.

@csabella

@terryjreedy

Right. I found where I rejected this in its current form, and added more on current uses and replacements.

@jfoo jfoo mannequin mentioned this pull request

Apr 10, 2022