gh-91398: Remove IDLE shell sidebar padding by BA-24 · Pull Request #32363 · python/cpython (original) (raw)
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
I noticed there was a white bar to the left in my IDLE, it stuck out like a soar thumb since I have a custom dark theme. This was not an issue with earlier versions.
Changing this line of code solves this issue and leaves the color choices up to the user.
I noticed there was a white bar to the left in my IDLE, it stuck out like a soar thumb since I have a custom dark theme. This was not an issue with earlier versions.
Changing this line of code solves this issue and leaves the color choices up to the user.
This comment was marked as outdated.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only affects the shell sidebar, which is the subject of bpo-45451. I made the change I requested.
On my Windows with dark theme, I prefer the change. But change needs evaluation on light and dark themes on all 3 major OSes. Will ask OP of issue for opinion. So not approved yet.
Remove white bar bpo-45451: Remove IDLE shell sidebar padding
@ambv This should be linked to the new GH issue when available. I overwrote the proposed change and will add blurb before merging.
This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.
I don't believe that this is needed for 3.9. It is certainly more of an issue for 3.10+.
There is a new CI button that requires CLA be signed, even for something trivial that should not require it. Adding a possibly false CLA signed label does not seem to fix that. If no signature, any workaround other than making a new PR myself?
bpo-45451: Remove IDLE shell sidebar padding gh-89614: Remove IDLE shell sidebar padding
I don't believe that this is needed for 3.9. It is certainly more of an issue for 3.10+.
There is a new CI button that requires CLA be signed, even for something trivial that should not require it. Adding a possibly false CLA signed label does not seem to fix that. If no signature, any workaround other than making a new PR myself?
That's my bad. I messed up the CLA thing, and, long story short, I ended up making a new identical issue on the bugs.python.org thing that can be found here
gh-89614: Remove IDLE shell sidebar padding gh-91398: Remove IDLE shell sidebar padding
@BA-24 could you try signing the CLA again? This should work now.
Hey, just updated to 3.11, is this getting merged or will I have to keep modifying the file manually?
Hey, just updated to 3.11, is this getting merged or will I have to keep modifying the file manually?
CI is failing because the news item is missing.
I am still planning to look at this soon.
Hey, just updated to 3.11, is this getting merged or will I have to keep modifying the file manually?
CI is failing because the news item is missing.
As far as I'm concerned it's a typo and does not need a news entry.
Hey, just updated to 3.12 and it seems this change still hasn't gone through. Updates?
I am still planning to look at this soon. (2022)
@terryjreedy Just a little reminder :) Is it possible for you to run all the actions (I do not have the permissions to do this) so we can see the current state of the PR?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terryjreedy you asked for previews on major oss, here is Linux.
Classic
Dark
@terryjreedy you asked for previews on major oss, here is Linux.
I think this looks great!
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.
If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.