bpo-31325: bug in RobotFileParser.parse by gvx · Pull Request #3259 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
• Loading
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
Fix bug in RobotFileParser().parse() Fix #31325: bug in RobotFileParser().parse()
| @@ -16,6 +16,8 @@ |
|---|
| __all__ = ["RobotFileParser"] |
| req_rate = collections.namedtuple('req_rate', 'requests seconds') |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change from "req_rate" to "RequestRate", afterall this is a class.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
Add please add tests, a documentation patch, and a news blurb.
Fix #31325: bug in RobotFileParser().parse() bpo-31325: bug in RobotFileParser.parse
