[3.6] bpo-31234: Enhance test_thread.test_forkinthread() (GH-3516) by miss-islington · Pull Request #3519 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

• test_thread.test_forkinthread() now waits until the thread completes.
• Check the status in the test method, not in the thread function
• Don't ignore RuntimeError anymore: since the commit
  346cbd3 (bpo-16500,
  os.register_at_fork(), os.fork() cannot fail anymore with
  RuntimeError.
• Replace 0.01 literal with a new POLL_SLEEP constant
• test_forkinthread(): test if os.fork() exists rather than testing
  the platform.
  (cherry picked from commit a15d155)

https://bugs.python.org/issue31234

• test_thread.test_forkinthread() now waits until the thread completes.
• Check the status in the test method, not in the thread function
• Don't ignore RuntimeError anymore: since the commit 346cbd3 (bpo-16500, os.register_at_fork(), os.fork() cannot fail anymore with RuntimeError.
• Replace 0.01 literal with a new POLL_SLEEP constant
• test_forkinthread(): test if os.fork() exists rather than testing the platform. (cherry picked from commit a15d155)

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!