bpo-31457: Allow for nested LoggerAdapter objects by ambv · Pull Request #3551 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Some of the proxied methods use internal Logger state which isn't proxied,
causing failures if an adapter is applied to another adapter.
This commit fixes the issue, adds a new test for the use case.
https://bugs.python.org/issue31457
Some of the proxied methods use internal Logger state which isn't proxied, causing failures if an adapter is applied to another adapter.
This commit fixes the issue, adds a new test for the use case.
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Some of the proxied methods use internal Logger state which isn't proxied, causing failures if an adapter is applied to another adapter.
This commit fixes the issue, adds a new test for the use case. (cherry picked from commit 1bbd482)
ambv pushed a commit that referenced this pull request
Some of the proxied methods use internal Logger state which isn't proxied, causing failures if an adapter is applied to another adapter.
This commit fixes the issue, adds a new test for the use case. (cherry picked from commit 1bbd482)