bpo-31170: Write unit test for Expat 2.2.4 UTF-8 bug by vstinner · Pull Request #3570 · python/cpython (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example you can test with two strings : (...)

Ok, I added these two examples as well.

FYI I tested and b'' (2 KB) worked well on Expat <= 2.2.3, but b'' failed (2 KB + 1).

I added 4 tests. I should now be enough to test for non-regression, no? If you want more tests, IMHO they should be written in Expat, not CPython ;-)

I only wanted to make sure that the fix was applied, not try all corner cases.