[2.7] bpo-29916: Include PyGetSetDef in C API extension documentation. (GH-831) by MSeifert04 · Pull Request #3609 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

| +-------------+------------------+-----------------------------------+ | | | | | ---------------------------------------------------------------------- | --------------- | -------------- | | | | Field | C Type | Meaning | | | +=============+==================+===================================+ | | | | | | name | const char \* | attribute name | |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is char * in 2.7.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I've seen that this caused the cherry-pick conflict in the other file, but thought that was only a documentation issue.

I should've checked the code.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

(cherry picked from commit da67e0d)