[2.7] bpo-31271: Fix an assertion failure in io.TextIOWrapper.write. (GH-3201) by miss-islington · Pull Request #3611 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation12 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

miss-islington

@orenmn @miss-islington

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

serhiy-storchaka

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether it is worth to backport this change, but if do this, unicode should be accepted.

@@ -1301,6 +1301,13 @@ textiowrapper_write(textio *self, PyObject *args)
Py_DECREF(text);
if (b == NULL)
return NULL;
if (!PyBytes_Check(b)) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unicode should be accepted too. _PyBytes_Join() in 2.7 supports unicode objects.

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Mariatta

Thanks @serhiy-storchaka.
@miss-islington won't be making the requested change (she is a bot), and I'm not familiar with C at all.
If no one else willing to backport to 2.7, maybe we can close the issue. I'll let you make that call :)

@serhiy-storchaka

Ah, I noticed that @miss-islington created a backporting PR, then it was closed and somebody created a new backporting PR. I missed that it was @miss-islington again!

@Mariatta

Yes sorry I mistakenly closed the other backport PR so I made miss-islington create another one... :(

@vstinner

@serhiy-storchaka: What should we do with this PR? Close it? The bot is not going to update its PR according to your review :-)

@serhiy-storchaka

I think it should be closed after creating a correct backport. Otherwise we risk to lose it. Re-adding the "needs backport to 2.7" label in #3201 will just trigger creating yet one incorrect backport.

@serhiy-storchaka

As @orenmn pointed on the tracker, the code is correct. Only the test need to be fixed.

@Mariatta

I'm closing this since the proper backport with tests passing has been done in #3951.

@serhiy-storchaka