bpo-31163: Adding return values to pathlib's rename and replace methods · Pull Request #4055 · python/cpython (original) (raw)
Hello,
this is a patch for bpo-31163. I am not an author, but I noticed the same thing and found the open issue (didn't know how to respond to it on bug tracker tho).
As I didn't see anyone opposing the change, I assumed it is OK, and tried to implement it.
This is my first attempt to contribute to Python, so please tell me if I missed something.
Regarding the code - not sure what the conventions in the standard library are, there were 3 options:
- target = PurePath(target)
- target = self.class(target) - I chose this one
- target = type(self)(target)
If I should've picked other option, please do correct me
Thanks!