bpo-31878: Fix _socket module compilation on Cygwin by embray · Pull Request #4137 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation13 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

In Cygwin, as on OSX, ioctl() is declared in sys/ioctl.h, and so needs this include. This is necessary for the _socket module to compile successfully on that platform.

https://bugs.python.org/issue31878

I think it is better to remove PYCC_VACPP in a separate commit.

I think it is better to remove PYCC_VACPP in a separate commit.

I agree, it's distributing to have both changes in the same PR.

Moreover, for the Cygwin PR, please explain your change in the commit message. Explain that your change adds the ioctl.h include on Cygwin.

It is in a separate commit, but the same PR. I will make a separate PR--it just seemed like very minor code cleanup.

Rebased: Dropped the PYCC_VACPP cleanup from this PR; the commit message already says I think all that needs to be said.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks @embray for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 27, 2017

(cherry picked from commit 63ae044)

GH-4145 is a backport of this pull request to the 3.6 branch.

Wait. For me, Cygwin means supporting a new platform. It was never supported officially. I'm against backporting such change.

"It is in a separate commit, but the same PR. I will make a separate PR--it just seemed like very minor code cleanup."

Please CC-me for your new "cleanup" PR, I like it ;-)

Thanks @embray for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

Sorry, @embray and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 63ae04461fb0cc93ca57cd151103a8dd295581d6 2.7