Misc. typos by luzpaz · Pull Request #4275 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation27 Commits5 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Most are trivial. Some are user facing. Found using:
codespell -q 3 -I '../cpy-whitelist.txt'
whereby the whitelist contained:

ans
dum
efford
iff
ot
nto
que
teh
te
thru
upto
whitespaces

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

Is it OK if I don't sign CLA.. I hereby release all trivial changes I am requesting for merge to the cpython project.

@@ -20,7 +20,7 @@
version: 2.59

-- This set of tests primarily tests the existence of the operator.
-- Additon, subtraction, rounding, and more overflows are tested

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test data is from a third party, so please take this change out. It does not make sense to maintain our own version.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all test data or just this file?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure just this file.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the exception of the ambigous 'catched', the replacements are correct.

@@ -2770,7 +2770,7 @@ def __init__(self):
import signal
self.signal = signal
self.signals = list(range(1, signal.NSIG))
# SIGKILL and SIGSTOP signals cannot be ignored nor catched
# SIGKILL and SIGSTOP signals cannot be ignored nor caught

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'catched' might be a misspelling of 'cached' rather than 'caught'. Victor Stinner might be the one who knows.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this edit is correct: "caught" was intended.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, irregular verb: caught is correct ;-)

@@ -20,7 +20,7 @@
version: 2.59

-- This set of tests primarily tests the existence of the operator.
-- Additon, subtraction, rounding, and more overflows are tested

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sure just this file.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Luzpaz: is your reluctance to sign the CLA the inconvenience of setting up a bpo account, or an objection to the CLA itself? (The actual e-signing is pretty trivial.)

If you only had submitted a couple of typos, there would be no issue (other than the fact we would hope to see more submissions from you). I am not sure about 58 (but please don't split this into 29 obviously trivial PRs ;-). Brett, your bot -- what is your opinion?

it comes from an external source so we should leave the typo as is.

The Travis failure is due to whitespace issues for
Include/pymem.h
Modules/_posixsubprocess.c
These were probably pre-existing. I will see if patchcheck on Windows fixes them.

FWIW as all of these are trivially correct obvious documentation or comment typo fixes my inclination is to not worry about the CLA being signed regardless of number of files. I'll be happy to merge this either way.

@@ -788,7 +788,7 @@ of the OpenSSL license here::
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* The licence and distribution terms for any publically available version or
* The licence and distribution terms for any publicly available version or

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't just change the license text, especially if this is a license of imported code.

@@ -164,7 +164,7 @@ each with their own argument patterns and help displays::

$ ./helm.py --help # top level help (launch and move)
$ ./helm.py launch --help # help for launch options
$ ./helm.py launch --missiles # set missiles=True and torpedos=False
$ ./helm.py launch --missiles # set missiles=True and torpedoes=False

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option name is torpedos.

@@ -100,7 +100,7 @@ dnl Check to see whether a particular set of modules exists. Similar to
dnl PKG_CHECK_MODULES(), but does not set variables or print errors.
dnl
dnl Please remember that m4 expands AC_REQUIRE([PKG_PROG_PKG_CONFIG])
dnl only at the first occurence in configure.ac, so if the first place
dnl only at the first occurrence in configure.ac, so if the first place

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this an imported file?

@@ -1504,7 +1504,7 @@ argument taking an iterable of handlers to be added to the root logger.
A class level attribute :attr:`~logging.handlers.SysLogHandler.append_nul` has
been added to :class:`~logging.handlers.SysLogHandler` to allow control of the
appending of the ``NUL`` (``\000``) byte to syslog records, since for some
deamons it is required while for others it is passed through to the log.
daemons it is required while for others it is passed through to the log.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the same typo in Lib/test/test_threading.py.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhiy-storchaka apologies, are you saying that daemons is correct here?
and in regards to Lib/test/test_threading.py i should fix:

def test_deamon_param(self):

so that it shows:
def test_daemon_param(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awaiting resolution of Serhiy's comments.

I will resubmit PR very soon with requested changes.

I hope you mean to push a new commit to this PR rather than closing this and submitting a new PR.

Unknown added 2 commits

November 5, 2017 07:52

I have made the requested changes; please review again

Sorry folks, my git-fu skills are pretty sad. Not sure how to squash everything in to 1 commit at this moment.

Thanks for making the requested changes!

@gpshead, @terryjreedy: please review the changes made to this pull request.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. You shouldn't squash everything into 1 commit. It is easier to review if keep separate incremental changes. All this will be squashed into 1 commit when be merged into master.

terryjreedy added a commit to terryjreedy/cpython that referenced this pull request

Nov 5, 2017

Manual partial backport of patch that fixed nearly 50 other files.

terryjreedy added a commit that referenced this pull request

Nov 6, 2017

Manual partial backport of patch that fixed nearly 50 other files.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plead guilty for "informations": I cannot accept that it's not possible to put a S to information in english! Sorry, I'm french :-)

@@ -2770,7 +2770,7 @@ def __init__(self):
import signal
self.signal = signal
self.signals = list(range(1, signal.NSIG))
# SIGKILL and SIGSTOP signals cannot be ignored nor catched
# SIGKILL and SIGSTOP signals cannot be ignored nor caught