bpo-32051: update multiprocessing doc by 1a1a11a · Pull Request #4469 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation15 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
Issue 32051 update multiprocessing doc [issue 32051] update multiprocessing doc
[issue 32051] update multiprocessing doc bpo-32051: update multiprocessing doc
I have signed the CLA, waiting for system to pass and re-check.
| @@ -1837,8 +1837,8 @@ Running the following commands creates a server for a single shared queue which |
|---|
| remote clients can access:: |
| >>> from multiprocessing.managers import BaseManager |
| >>> import queue |
| >>> queue = queue.Queue() |
| >>> from multiprocessing import Queue |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think multiprocessing.Queue is needed here. We don't communicate between different processes in the same machine so using queue.Queue is OK.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the comment, what should I do now? Should I make the change and submit a new pull request?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,2 @@ |
|---|
| Remove name conflict under "Using a remove manager" section, the original |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add a NEWS entry for trivial documentation changes. Please delete this file.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this.
I have made the requested changes; please review again.
Thanks for making the requested changes!
@berkerpeksag: please review the changes made to this pull request.
Remove name conflict under "Using a remove manager" section
bpo-32051: update multiprocessing doc bpo-32051: update multiprocessing doc [skip news]
bpo-32051: update multiprocessing doc [skip news] bpo-32051: update multiprocessing doc skip-news
bpo-32051: update multiprocessing doc skip-news bpo-32051: update multiprocessing doc [skip-news]
btw, how do I add skip news label?
bpo-32051: update multiprocessing doc [skip-news] bpo-32051: update multiprocessing doc
Thanks @1a1a11a for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
(cherry picked from commit c172fc5)
Thanks!
Labels can only be set by Python core developers or bots like bedevere.