bpo-32096: Remove obj and mem from _PyRuntime by vstinner · Pull Request #4532 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits7 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
bpo-32096, bpo-30860: Partially revert the commit
2ebc5ce:
- Move structures back from Include/internal/mem.h to
Objects/obmalloc.c - Remove _PyObject_Initialize() and _PyMem_Initialize()
- Remove Include/internal/pymalloc.h
PyMem_RawMalloc() and Py_DecodeLocale() can be called again before
_PyRuntimeState_Init().
https://bugs.python.org/issue32096
bpo-32096, bpo-30860: Partially revert the commit 2ebc5ce:
- Move structures back from Include/internal/mem.h to Objects/obmalloc.c
- Remove _PyObject_Initialize() and _PyMem_Initialize()
- Remove Include/internal/pymalloc.h
PyMem_RawMalloc() and Py_DecodeLocale() can be called again before _PyRuntimeState_Init().
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
Make sure that it's possible to call Py_DecodeLocale(), and then call Py_SetProgramName() with the decoded string, before Py_Initialize().
Co-Authored-By: Eric Snow ericsnowcurrently@gmail.com
| @@ -0,0 +1,4 @@ |
|---|
| Revert memory allocator changes in the C API: move structures back from |
| _PyRuntime to Objects/obmalloc.c. The memory allocators are now initialized |
| again statically, and so PyMem_RawMalloc() and Py_DecodeLocale() can be |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight grammar tweak: "now initialized again" -> "once again initialized"
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This was referenced
Nov 24, 2017