bpo-25910: Fixes redirection from http to https by CuriousLearner · Pull Request #4674 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation22 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
| releases, it also offers a number of features via pure Python |
|---|
| extensions that are not available in other language bindings. There |
| is an active wxPython user and developer community. |
| wxPython (https://www.wxpython.org) is the Python binding for wxwidgets. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind to create a link?
| extensions that are not available in other language bindings. There |
|---|
| is an active wxPython user and developer community. |
| wxPython (https://www.wxpython.org) is the Python binding for wxwidgets. |
| While it often lags slightly behind the official wxWidgets releases, it also |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vadmium asked you to not reformat links like this, please restrict this PR to HTTPS.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for that. I just extracted the same old changes from the earlier patch. I'll fix this.
| @@ -170,8 +170,8 @@ offender. |
|---|
| How do I make an executable from a Python script? |
| ------------------------------------------------- |
| See http://cx-freeze.sourceforge.net/ for a distutils extension that allows you |
| to create console and GUI executables from Python code. |
| See https://anthony-tuininga.github.io/cx\_Freeze/ for a distutils extension |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a link. You may be able to omit the url here, since it's written in a previous section (check the HTML output, I'm not sure).
| @@ -694,7 +694,7 @@ implementation, extension code, and this documentation: |
|---|
| You should have received a copy of the CC0 Public Domain Dedication along |
| with this software. If not, see |
| http://creativecommons.org/publicdomain/zero/1.0/. |
| https://creativecommons.org/publicdomain/zero/1.0/. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text is a license. Is it ok to modify a license?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about that. Should I ask this on the bug?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok. I take the responsability for this change ;-)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright thanks :)
| :mod:`distutils` extension (see :ref:`extending-distutils`) which wraps |
|---|
| Python scripts into executable Windows programs (:file:`{*}.exe` files). |
| When you have done this, you can distribute your application without |
| requiring your users to install Python. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, please revert this change, only replace the HTTP link.
| @@ -1832,8 +1832,8 @@ https://pypi.python.org/pypi/unittest2. |
|---|
| When used from the command line, the module can automatically discover |
| tests. It's not as fancy as `py.test http://pytest.org`__ or |
| `nose http://code.google.com/p/python-nose/`__, but provides a simple way |
| to run tests kept within a set of package directories. For example, |
| `nose https://code.google.com/archive/p/python-nose`__, but provides a |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you're right about it. The make linkcheck command showed me this as a 301. So, I updated it to point to this link.
| @@ -238,8 +238,8 @@ and the ``__annotations__`` attribute. |
|---|
| and Guido van Rossum. Implemented by Ivan Levkivskyi. |
| Tools that use or will use the new syntax: |
| `mypy http://github.com/python/mypy`_, |
| `pytype http://github.com/google/pytype`_, PyCharm, etc. |
| `mypy https://github.com/python/mypy`_, |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
I have made the requested changes; please review again
Thanks for making the requested changes!
@vstinner: please review the changes made to this pull request.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
| @@ -694,7 +694,7 @@ implementation, extension code, and this documentation: |
|---|
| You should have received a copy of the CC0 Public Domain Dedication along |
| with this software. If not, see |
| http://creativecommons.org/publicdomain/zero/1.0/. |
| https://creativecommons.org/publicdomain/zero/1.0/. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok. I take the responsability for this change ;-)
Thanks @CuriousLearner for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
Sorry, @CuriousLearner and @vstinner, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.cherry_picker 1b4587a2462fc05a14be87123083322103a1f55b 3.6
Sorry, please ignore the backport to 3.6 noise!