bpo-29469: Remove unnecessary peephole optimizer by methane · Pull Request #4863 · python/cpython (original) (raw)

Removing BUILD_TUPLE folding makes regression on MAKE_FUNCTION:

before:

 459         204 LOAD_CONST              96 ((None, None))
             206 LOAD_CONST              39 (<code object _spec_from_module at 0x7f7d61834420, file "_bootstrap.py", line 459>)
             208 LOAD_CONST              40 ('_spec_from_module')
             210 MAKE_FUNCTION            1
             212 STORE_NAME              22 (_spec_from_module)

after:

 459         204 LOAD_CONST               1 (None)
             206 LOAD_CONST               1 (None)
             208 BUILD_TUPLE              2
             210 LOAD_CONST              39 (<code object _spec_from_module at 0x7f5f36a2c5d0, file "_bootstrap.py", line 459>)
             212 LOAD_CONST              40 ('_spec_from_module')
             214 MAKE_FUNCTION            1
             216 STORE_NAME              22 (_spec_from_module)