[backport to 3.5] bpo-27122: Fix comment to point to correct issue number (#47) by berkerpeksag · Pull Request #50 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

It took me quite a bit to figure out what this was referring to,
since the given issue number is wrong, and the original commit
message I found through git blame lists a different, also wrong
issue number... see https://bugs.python.org/issue27122#msg279449

(cherry picked from commit af88e7e)

It took me quite a bit to figure out what this was referring to, since the given issue number is wrong, and the original commit message I found through git blame lists a different, also wrong issue number... see https://bugs.python.org/issue27122#msg279449

(cherry picked from commit af88e7e)

Thanks for the approvals, Mariatta.

GitHub overwrote the original author's name again: c6d2f49

Mr3x33 added a commit to Mr3x33/cpython that referenced this pull request

Sep 17, 2021

colesbury referenced this pull request in colesbury/nogil

Oct 6, 2021

Once the threads object queue is empty, other threads may explicitly merge reference counts immediately. It's no longer safe for the original thread to do RC operations because of races with accesses to ob_ref_local.

This ensures that the queue is empty when it's removed from the hashtable mapping thread-id to queue. There are still other RC operations that can happen during thread destruction, so the call to _Py_queue_destroy will probably need to be moved.

See #50

colesbury referenced this pull request in colesbury/nogil

Oct 6, 2021

A partially initialized thread may have an entry in the interpreter without a corresponding entry in the biased-refcounting hashtable.

See #50

jaraco pushed a commit that referenced this pull request

Dec 2, 2022