[WIP] bpo-32654: Fixes for Android API 19 by vstinner · Pull Request #5305 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits10 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Declare mmap() prototype on API < 21
Avoid setlocale(LC_ALL, NULL) in Py_Main() on API < 20
pystrtod.c: avoid localeconv() on API < 21
_Py_GetLocaleconvNumeric(): avoid localeconv() on API < 20, use
hardcoded values.

https://bugs.python.org/issue32654

Declare mmap() prototype on API < 21
Avoid setlocale(LC_ALL, NULL) in Py_Main() on API < 20
pystrtod.c: avoid localeconv() on API < 21
_Py_GetLocaleconvNumeric(): avoid localeconv() on API < 20, use hardcoded values.

vstinner changed the title~~bpo-32654: Fixes for Android API 19~~ [WIP] bpo-32654: Fixes for Android API 19

Jan 24, 2018

_Py_GetLocaleconvNumeric(): use an empty string for thousands_sep and grouping
Fix pystrtod.c: really don't call localeconv() on old Android

@yan12125: Would you mind to review and/or test this PR?

Sorry, I may not be able to for now. I don't have a working android-19 device, and I don't think testing on an emulator can give trustworthy results. In my experience there are lots of bugs occur on emulators only.

Sorry, I may not be able to for now. I don't have a working android-19 device, and I don't think testing on an emulator can give trustworthy results. In my experience there are lots of bugs occur on emulators only.

The question is not if this PR is enough to fix all API 19 issues, just if it doesn't make things worse :-D

Oh, of course it won't be worse than crash immediately after startup :)

I can have a check on emulators, possibly this weekend.

@@ -177,8 +176,13 @@ _PyOS_ascii_strtod(const char nptr, char *endptr)

fail_pos = NULL;

locale_data = localeconv();
#if defined(__ANDROID_API__) and __ANDROID_API__ < 21

[WIP] bpo-32654: Fixes for Android API 19 by vstinner · Pull Request #5305 · python/cpython (original) (raw)

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment