bpo-32628: support DirectoryIndex for http server by epaulson · Pull Request #5308 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

epaulson

SimpleHTTPRequestHandler is hard-coded to only use index.html or index.htm
as files to serve for a request for a directory. With this change, this list
can be modified, ala the DirectoryIndex directive of an Apache web server.

https://bugs.python.org/issue32628

@epaulson

SimpleHTTPRequestHandler is hard-coded to only use index.html or index.htm as files to serve for a request for a directory. With this change, this list can be modified, ala the DirectoryIndex directive of an Apache web server.

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@epaulson

@MaxwellDupre

Could you amend versionadded, please? Lets try for 3.11.

@AlexWaygood

Could you amend versionadded, please? Lets try for 3.11.

@MaxwellDupre, just so you know, the beta release for 3.11 was released today, meaning 3.11 is now in feature freeze. 3.11 is now only accepting bugfixes, meaning new features can now only be added to 3.12.

@epaulson

I got a somewhat skeptical review in #76809 so I'm not sure what the path forward might be. Happy to update it to 3.12 but I don't know that it's ever going to make it in, even updated.

@AlexWaygood

I got a somewhat skeptical review in #76809 so I'm not sure what the path forward might be. Happy to update it to 3.12 but I don't know that it's ever going to make it in, even updated.

I am neither a core developer (I'm a triager) nor a frequent user of the http module, so I can't really comment on that, I'm afraid :/

@github-actions

This PR is stale because it has been open for 30 days with no activity.

@python-cla-bot

@github-actions GitHub Actions

This PR is stale because it has been open for 30 days with no activity.