bpo-33051: IDLE: Separate editor options from the general tab in config by csabella · Pull Request #6082 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

I am skimming through some of your open IDLE patches before quitting for the night. In particular, are there any that can/should be merged before 3.7.0c1 next Tuesday? This looks like a straightforward cut/paste with light editing. I still must look at dialog itself. If I like it, YES.

@terryjreedy I looked through the other open IDLE patches I have. Two of them have new tests for editor.py, so those would probably be too big to try to look at before Tuesday. I don't know if this is one you'd want to check before then - #5011.

Closing this was unintentional but I need to see if I can recreate the branch to reopen it.

Restored and rebased to master.

Closing as obsolete. init_validators was separately added and used on the existing GenPage. #26621 is a similar patch that separated windows preferences from Shell and Edit preferences. I did it after moving helplist to extensions tab and creating an ExtPage class. Moving indent spaces, #22954, completes the major changes we start around 3 years ago.