bpo-29673: Some gdb macros are broken in 3.6 · Pull Request #6126 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation11 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ghost changed the titlefix gdb scripts pystack and pystackv bpo-29673: ome gdb macros are broken in 3.6

Mar 16, 2018

ghost changed the titlebpo-29673: ome gdb macros are broken in 3.6 bpo-29673: Some gdb macros are broken in 3.6

Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including a NEWS entry. However, this is a bit too detailed. See a current changelog to get a sense of the level of detail we use. This kind of detail might be appropriate for a commit message.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo Ned's NEWS file comment. (I am really surprised this little hack has lived this long...)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @smontanaro , and the changes, @Traceur759. Almost there!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit: we try to keep the ACKs list in alphabetical order by family name. So please insert your name in the "P" section. Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for condensing the NEWS entry. But I think it is still too detailed and does not really answer the question of what was fixed; why it was fixed is not so important here. Also, if you wish, you can add your name here. An example from the Developer's Guide:

Fix warning message when os.chdir() fails inside
test.support.temp_cwd(). Patch by Chris Jerdonek.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

Thanks @Traceur759 for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 6, 2018

(cherry picked from commit 3a9ccee)

Co-authored-by: Marcel Plch gmarcel.plch@gmail.com

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 6, 2018

(cherry picked from commit 3a9ccee)

Co-authored-by: Marcel Plch gmarcel.plch@gmail.com

ned-deily pushed a commit that referenced this pull request

Apr 6, 2018

)

(cherry picked from commit 3a9ccee)

Co-authored-by: Marcel Plch gmarcel.plch@gmail.com

ned-deily pushed a commit that referenced this pull request

Apr 6, 2018

)

(cherry picked from commit 3a9ccee)

Co-authored-by: Marcel Plch gmarcel.plch@gmail.com