[3.7] bpo-33061: Add missing 'NoReturn' to all in typing.py (GH-6127) by ilevkivskyi · Pull Request #6162 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

ilevkivskyi

@aetracht

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@ilevkivskyi

@aetracht So what is the situation with your CLA? It looks like it is still not found.

@aetracht

I really have no idea: I went to an incognito browser and opened my profile. After logging in, I see the expected GitHub username (aetracht) and email (allen@duolingo.com). I guess I'll try creating a new CLA and see if that helps.

@aetracht

gvanrossum

@ilevkivskyi

@aetracht Are you sure you have followed all CLA instructions? (I don't know how it is done now. Also this is not a request to action, just a question, please re-read the CLA instructions and check if you followed all steps.)

@aetracht

Following the steps in: https://devguide.python.org/pullrequest/#licensing

  1. Register for an account on BPO: https://bugs.python.org/user28094 exists with my name, login name, GitHub Name, and email address.
    1. Curiously, the system seems to have a problem with my email address: sometimes it shows my personal email (aetracht@gmail.com), and sometimes my work email (allen@duolingo.com). I don't know if something is wrong there.
  2. Make suer my GitHub username is listed in the "Your Details" section at bpo: It says aetracht which matches my profile at https://github.com/aetracht.
  3. Fill out and sign the PSF contributor form.
    Python Contributor Agreement Form - signed (2).pdf
    1. The username from the CLA is AllenTracht which matches my bpo login name AllenTracht
    2. The only thing that looks at all curious is the email.

At this point I'm quite at a loss. I'll try one more time, all in an incognito window and see if that helps.

@aetracht

@gvanrossum

There is a manual review step involved, which usually takes a few business days? (Maybe typically 1?)

@bedevere-bot

@ilevkivskyi: Please replace # with GH- in the commit message next time. Thanks!

@ilevkivskyi

OK, CLA is still red, but since this is just one line backport (and beta 3 is in 3 days) I am merging this. But please, sort it out before your next PR. Thanks!