bpo-33274: Compliance with DOM L1: return removed attribute by arikrupnik · Pull Request #6462 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
Thanks again to your contribution and we look forward to looking at it!
Compliance with DOM L1: return removed attribute #33274 Compliance with DOM L1: return removed attribute
#33274 Compliance with DOM L1: return removed attribute bpo-33274: Compliance with DOM L1: return removed attribute
@arikrupnik, Thanks for your PR. I see that additions to the PR have been requested on the bug tracker. Please note you should make the PR against the "master" branch, not the "3.6" branch. If a core developer decides to merge the PR to master, they will also decide whether to backport the change to other branches. Thus, I'm closing this PR against 3.6.
https://devguide.python.org/pullrequest/
Thank you @ned-deily. Is it the practice in CPython to open new PRs rather than updating existing ones if one pushes additional commits to the branch?
When a PR is made against the wrong branch, yes.
@arikrupnik It's fine to push additional commits to an open PR. But as @terryjreedy notes, the issue here was that the target cpython branch was incorrect and, while I have since found that you can edit the PR to change the target branch, as a practical matter I don't think that would ever be useful with the main cpython branches.