bpo-33131: Upgrade ensurepip to pip 10.0.1 by pfmoore · Pull Request #6546 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation17 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

We should also backport this to all the relevant versions that are still accepting backports.

Agreed - thanks for the reminder. I had that on my list to do just before merge (it's just adding labels and letting the bot do its thing, I believe)

Given the pip level API compatibility break, I think the main branches it would make sense to backport to are 2.7 and 3.7.

For 3.6.x, even though it's nominally still open to general bug fixes, I figure it makes sense to let folks decide for themselves if they want to stick with 9.0.x for now.

The test failure is genuine - ensurepip currently relies on pip.main to let it run pip directly from the wheel archive without unpacking it to a temporary directory first.

@ncoghlan Yeah my bad. I saw it earlier, it's an easy fix just getting to it now.

Thanks @pfmoore for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 20, 2018

Upgrade ensurepip to bundle pip 10.0.1 (cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore p.f.moore@gmail.com

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 20, 2018

Upgrade ensurepip to bundle pip 10.0.1 (cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore p.f.moore@gmail.com

If we're upgrading 2.7, we should upgrade 3.6, too. Otherwise, 3.6 users are going to be harangued by pip upgrade messages.

Um. OK. I don't have an opinion myself, so I'm happy to go with that - but given that I've hit merge and the bots are doing their thing, what do I need to do now to upgrade 3.6?

You just need to add the "needs backport to 3.6" label.

Cool! I thought I had to do that before I merged. Yet again, I'm impressed by how easy the new workflow is :-)

Thanks @pfmoore for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 20, 2018

Upgrade ensurepip to bundle pip 10.0.1 (cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore p.f.moore@gmail.com

miss-islington added a commit that referenced this pull request

Apr 20, 2018

Upgrade ensurepip to bundle pip 10.0.1 (cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore p.f.moore@gmail.com

miss-islington added a commit that referenced this pull request

Apr 20, 2018

Upgrade ensurepip to bundle pip 10.0.1 (cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore p.f.moore@gmail.com

miss-islington added a commit that referenced this pull request

Apr 20, 2018

Upgrade ensurepip to bundle pip 10.0.1 (cherry picked from commit 0399cf9)

Co-authored-by: Paul Moore p.f.moore@gmail.com

The bots can even cope if you miss that they already created the backport PR and mistakenly re-add the backport label. They're pretty cool :)

The bots are incredibly impressive. Genuinely feels like magic.