Detect working functions, not just existence by grimreaper · Pull Request #6849 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

autotools as a mechanism to detect that the functions it detects works,
not just exists. For these functions, use those macros.

The CI is failing with:

Traceback (most recent call last):
  File "/home/travis/build/python/cpython/Lib/test/test_logging.py", line 3389, in test_time
    r.created = time.mktime(dt.astimezone(None).timetuple())
AttributeError: module 'time' has no attribute 'mktime'
``

autotools as a mechanism to detect that the functions it detects works, not just exists. For these functions, use those macros.

Thank you for your interest in improving CPython. This is not a trivial change and would require an issue to be created on bugs.python.org, as previously requested. If you are interested in pursuing this, please open an issue on the bug tracker and reopen this pull request with the bpo number in the title as per the devguide. Also, please resolve the merge conflicts once reopened. Thanks!