bpo-33604: Remove deprecated HMAC default value marked for removal in 3.8 by Carreau · Pull Request #7063 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some minor edits. overall I'm okay with this but lets wait for the PR marking it fully deprecated in 3.7 to go in first.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
I made some minor edits
AH, yes, thank you, much better.
overall I'm okay with this but lets wait for the PR marking it fully deprecated in 3.7 to go in first.
Yes that was the plan.
I rebased because of conflict.
I have made the requested changes; please review again
Thanks for making the requested changes!
@gpshead: please review the changes made to this pull request.
… 3.8
HMAC's digestmod was deprecated marked for removal in 3.6, then bumped to 3.8
lets not mention the old behavior in the docstring and explicitly document that the digestmod parameter is required.
Thanks, Much appreciated. I'm guessing you'll be at the core-dev sprint, and wish you all to enjoy it (but still take some time off).
moreati added a commit to moreati/cpython that referenced this pull request
