bpo-32458: Increase TLS timeout in test_asyncio by vstinner · Pull Request #7157 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits2 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

test_asyncio: Increase test_start_tls_server_1() client timeout from
5 seconds to 60 seconds, and server timeout from 10 to 120 seconds.

The timeout is only used to check if the test hangs, but the 5
seconds limit is commonly reached on slow CIs like Travis CI and some
buildbots.

https://bugs.python.org/issue32458

test_asyncio: Increase test_start_tls_server_1() client timeout from 5 seconds to 60 seconds, and server timeout from 10 to 120 seconds.

The timeout is only used to check if the test hangs, but the 5 seconds limit is commonly reached on slow CIs like Travis CI and some buildbots.

I tested manually my PR on my laptop and I failed to make the test fail again. I opened 4 terminals to run commands in parallel:

(1) ./python -m test test_asyncio -m test_start_tls_server_1 -F
(2) ./python -m test -j16 -r
(3) ./python -m test -j16 -r
(4) ./python -m test -j16 -r

The system load was larger than 42.

Oh, the PR #5054 disabled SSL tests on the proactor event loop: my PR now also reenables these tests. Let's see if test_asyncio of my PR pass on AppVeyor ;-)

Sorry, need to close this as it's in direct conflict with #7130 that I'm about to merge :(