[3.7] bpo-22087: Fix Policy.get_event_loop() to detect fork (GH-7208) by miss-islington · Pull Request #7215 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation6 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Original patch by Dan O'Reilly. (cherry picked from commit 5d97b7b)

Co-authored-by: Yury Selivanov yury@magic.io

1st1 approved these changes May 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IHMO it's too late for 3.7.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

https://bugs.python.org/issue22087 is as old as asyncio and people learnt how to work around the issue. I don't think that there is any kind of urgency to merge this change into 3.7. I would prefer to leave 3.7 unchanged, and test the change in 3.8 instead. It's too late for 3.7, we are very close to the 3.7rc1.

I don't see why it's too late.

is as old as asyncio and people learnt how to work around the issue

This doesn't sound as an actual explanation why this shouldn't be merged. I don't see any technical problem with this patch or how it can possibly break anything.

@1st1: Backport status check is done, and it's a success ✅ .