bpo-33687: uu: fix call to os.chmod by timofurrer · Pull Request #7282 · python/cpython (original) (raw)

Why test_decodetwice was changed? Seems this breaks the purpose of this test.

I see, there is something off with the current test implementation - I'll have a look at it.
However, all those tests have side-effects - that's why I needed to make this change in the first place.
The side-effect is actually confirmed by the current implementation, because the uu.Error is still raised ..

Try to create a file with a mode 0o444 and check that the resulting file is read-only

Why is that? I could argue that this would be a test for os.chmod itself and I don't want the uu test to fail just because something is off with os.chmod ...
Any advice on how you want to handle such cases usually?