gh-59795: distinct python-config from pkg-config python by haubi · Pull Request #737 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation13 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Fix output of 'python-config' for creating loadable Python modules. Fix output of 'pkg-config python' for linking against the interpreter.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please re base this or want new taker for this?
See more recent bpo-36721 (#80902) which also addresses this area.
I'm not sure that bpo-36721 (#80902) is related. Misc/python-config.sh.in still uses SYSLIBS, whereas Misc/python.pc.in doesn't.
This PR is stale because it has been open for 30 days with no activity.
This PR is stale because it has been open for 30 days with no activity.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has merge conflicts now.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
This PR is stale because it has been open for 30 days with no activity.
Unfortunately, meanwhile I have moved on to completely different tasks, and have neither the environment nor the time any more to look into that again: Feel free to pick up!
This PR is stale because it has been open for 30 days with no activity.
bpo-15590: distinct python-config from pkg-config python gh-59795: distinct python-config from pkg-config python
Meta: added GitHub links to OP and comments for easier navigation.
Unfortunately, meanwhile I have moved on to completely different tasks, and have neither the environment nor the time any more to look into that again: Feel free to pick up!
In that case, I propose to close this PR. If anybody wants to pick this up, they'll be better off by starting from scratch; the build system has seen huge changes the recent years.
We should also consider closing the linked issue; I'm unsure if this is a real problem anymore.