bpo-33781: audioop: enhance rounding double as int by vstinner · Pull Request #7447 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Move the floor() call into fbound() to call floor() on a double rather than an int. The change might enhance the rounding.

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 6, 2018

Move the floor() call into fbound() to call floor() on a double rather than an int. The change should enhance the rounding.

Document also (int)double rounding mode. (cherry picked from commit 45e4efb)

Co-authored-by: Victor Stinner vstinner@redhat.com

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 6, 2018

Move the floor() call into fbound() to call floor() on a double rather than an int. The change should enhance the rounding.

Document also (int)double rounding mode. (cherry picked from commit 45e4efb)

Co-authored-by: Victor Stinner vstinner@redhat.com

Sorry, @vstinner, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 45e4efba7fa2abe61d25e4f8b5bf482e19ff1280 2.7

miss-islington added a commit that referenced this pull request

Jun 6, 2018

Move the floor() call into fbound() to call floor() on a double rather than an int. The change should enhance the rounding.

Document also (int)double rounding mode. (cherry picked from commit 45e4efb)

Co-authored-by: Victor Stinner vstinner@redhat.com

vstinner added a commit that referenced this pull request

Jun 6, 2018

Move the floor() call into fbound() to call floor() on a double rather than an int. The change should enhance the rounding.

Document also (int)double rounding mode.

(cherry picked from commit 45e4efb)

vstinner added a commit that referenced this pull request

Jun 6, 2018

Move the floor() call into fbound() to call floor() on a double rather than an int. The change should enhance the rounding.

Document also (int)double rounding mode. (cherry picked from commit 45e4efb)

Co-authored-by: Victor Stinner vstinner@redhat.com