bpo-33274: Compliance with DOM L1: return removed attribute by arikrupnik · Pull Request #7465 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This was referenced
Jun 7, 2018
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a note in the xml.dom.minidom documentation about the change, but... I'm not at all sure how to reasonably fit it in, given the docs refer to the DOM Level 1 specification for actual API details.
We might just need to leave that out, aside from the change blurb.
| @@ -0,0 +1,3 @@ |
|---|
| W3C DOM Level 1 specifies return value of Element.removeAttributeNode() as |
| "The Attr node that was removed." xml.dom.minidom now complies with this |
| requirement |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing period, please. (Yes, I'm picky!)
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
I have made the requested changes; please review again
Thanks for making the requested changes!
@freddrake: please review the changes made to this pull request.
@freddrake: Please replace # with GH- in the commit message next time. Thanks!