bpo-30317, test_multiprocessing: fix test_timeout() by vstinner · Pull Request #7957 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

vstinner

Tolerate a different of 50 ms, instead of just 30 ms, in
test_timeout() of multiprocessing tests. This change should fix such
test failure on Windows:

======================================================================
FAIL: test_timeout (test.test_multiprocessing_spawn.WithProcessesTestQueue)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "lib\test\_test_multiprocessing.py", line 753, in test_timeout
    self.assertGreaterEqual(delta, 0.170)
AssertionError: 0.16138982772827148 not greater than or equal to 0.17

https://bugs.python.org/issue30317

@vstinner

Tolerate a different of 50 ms, instead of just 30 ms, in test_timeout() of multiprocessing tests. This change should fix such test failure on Windows:

====================================================================== FAIL: test_timeout (test.test_multiprocessing_spawn.WithProcessesTestQueue)

Traceback (most recent call last): File "lib\test_test_multiprocessing.py", line 753, in test_timeout self.assertGreaterEqual(delta, 0.170) AssertionError: 0.16138982772827148 not greater than or equal to 0.17

@vstinner

Linux-PR_20180627.18 failed

multissltests failed on downloading OpenSSL from openssl.org...

@miss-islington

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 27, 2018

@vstinner @miss-islington

Tolerate a different of 50 ms, instead of just 30 ms, in test_timeout() of multiprocessing tests. This change should fix such test failure on Windows:

FAIL: test_timeout (test.test_multiprocessing_spawn.WithProcessesTestQueue) Traceback (most recent call last): File "lib\test_test_multiprocessing.py", line 753, in test_timeout self.assertGreaterEqual(delta, 0.170) AssertionError: 0.16138982772827148 not greater than or equal to 0.17 (cherry picked from commit f15f66d)

Co-authored-by: Victor Stinner vstinner@redhat.com

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 27, 2018

@vstinner @miss-islington

Tolerate a different of 50 ms, instead of just 30 ms, in test_timeout() of multiprocessing tests. This change should fix such test failure on Windows:

FAIL: test_timeout (test.test_multiprocessing_spawn.WithProcessesTestQueue) Traceback (most recent call last): File "lib\test_test_multiprocessing.py", line 753, in test_timeout self.assertGreaterEqual(delta, 0.170) AssertionError: 0.16138982772827148 not greater than or equal to 0.17 (cherry picked from commit f15f66d)

Co-authored-by: Victor Stinner vstinner@redhat.com

@bedevere-bot

miss-islington added a commit that referenced this pull request

Jun 27, 2018

@miss-islington @vstinner

Tolerate a different of 50 ms, instead of just 30 ms, in test_timeout() of multiprocessing tests. This change should fix such test failure on Windows:

FAIL: test_timeout (test.test_multiprocessing_spawn.WithProcessesTestQueue) Traceback (most recent call last): File "lib\test_test_multiprocessing.py", line 753, in test_timeout self.assertGreaterEqual(delta, 0.170) AssertionError: 0.16138982772827148 not greater than or equal to 0.17 (cherry picked from commit f15f66d)

Co-authored-by: Victor Stinner vstinner@redhat.com

miss-islington added a commit that referenced this pull request

Jun 27, 2018

@miss-islington @vstinner

Tolerate a different of 50 ms, instead of just 30 ms, in test_timeout() of multiprocessing tests. This change should fix such test failure on Windows:

FAIL: test_timeout (test.test_multiprocessing_spawn.WithProcessesTestQueue) Traceback (most recent call last): File "lib\test_test_multiprocessing.py", line 753, in test_timeout self.assertGreaterEqual(delta, 0.170) AssertionError: 0.16138982772827148 not greater than or equal to 0.17 (cherry picked from commit f15f66d)

Co-authored-by: Victor Stinner vstinner@redhat.com