bpo-25094: Fix test_tools.test_sundry() on Windows by vstinner · Pull Request #8406 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation4 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
When Python is installed on Windows, python -m test test_tools
failed. Fix test_sundry() test by fixing sys.argv before loading
scripts. Run 2to3 with one argument: test_tools/test_sundry.py.
Modify also the unit test to unload all modules which have been
loaded by the test. Moreover, use CleanImport() context manager to
make sure that 'name' module is not already loaded.
https://bugs.python.org/issue25094
When Python is installed on Windows, python -m test test_tools failed because it tried to run Tools\scripts\2to3.py which requires an argument. Skip this script. On other platforms or on Windows but when run from source code (not installed), the script is called "2to3" instead of "2to.py" and so was already skipped.
Modify also the unit test to unload all modules which have been loaded by the test.
I tested manually my fix on an installed Python 3.6 by replacing C:\Python36\Lib\test\test_tools\test_sundry.py: the fix works as expected.
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
When Python is installed on Windows, python -m test test_tools failed because it tried to run Tools\scripts\2to3.py which requires an argument. Skip this script. On other platforms or on Windows but when run from source code (not installed), the script is called "2to3" instead of "2to.py" and so was already skipped.
Modify also the unit test to unload all modules which have been loaded by the test. (cherry picked from commit 752d4b7)
Co-authored-by: Victor Stinner vstinner@redhat.com
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
When Python is installed on Windows, python -m test test_tools failed because it tried to run Tools\scripts\2to3.py which requires an argument. Skip this script. On other platforms or on Windows but when run from source code (not installed), the script is called "2to3" instead of "2to.py" and so was already skipped.
Modify also the unit test to unload all modules which have been loaded by the test. (cherry picked from commit 752d4b7)
Co-authored-by: Victor Stinner vstinner@redhat.com
miss-islington added a commit that referenced this pull request
When Python is installed on Windows, python -m test test_tools failed because it tried to run Tools\scripts\2to3.py which requires an argument. Skip this script. On other platforms or on Windows but when run from source code (not installed), the script is called "2to3" instead of "2to.py" and so was already skipped.
Modify also the unit test to unload all modules which have been loaded by the test. (cherry picked from commit 752d4b7)
Co-authored-by: Victor Stinner vstinner@redhat.com
vstinner added a commit that referenced this pull request
When Python is installed on Windows, python -m test test_tools failed because it tried to run Tools\scripts\2to3.py which requires an argument. Skip this script. On other platforms or on Windows but when run from source code (not installed), the script is called "2to3" instead of "2to.py" and so was already skipped.
Modify also the unit test to unload all modules which have been loaded by the test. (cherry picked from commit 752d4b7)
Co-authored-by: Victor Stinner vstinner@redhat.com