bpo-29924: Remove useless argument by SylvainDe · Pull Request #854 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Haypo may be the most relevant reviewer for this.

I've signed the CLA.

The change LGTM, but it seems like the signature wasn't validated yet. Let's wait 1 or 2 days and check again if the bot is happy.

Did you set your GitHub username in your bugs.python.org profile?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but wait for the CLA tag.

@Haypo Thanks for the quick reply. I've just added my Github handle to my profile on the bug.report. Let's wait and see :-)

On this tiny change, I didn't ask you to add yourself to Misc/ACKS, but you may have to do it for your next change.

Thanks for your first contribution to CPython! I made the mistake, but I'm happy that someone found it, and even better, fixed it!