bpo-34546: Add Standard Zip Encryption support to zipmodule by mitsuo0114 · Pull Request #9060 · python/cpython (original) (raw)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions should have lowercase_with_underscores names rather than CamelCase.

Also, since this generates an encrypting function, the name should reflect this, e.g. make_zip_encrypter.

I realize _ZipEncrypter was likely chosen to reflect that this is class-like (e.g. it is stateful), but I personally find it more confusing than helpful.