closes bpo-34652: Always disable lchmod on Linux. by benjaminp · Pull Request #9234 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Symbolic link modes cannot be changed on Linux, so there's no point ever trying to use this function.
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
(cherry picked from commit 40caa05)
Co-authored-by: Benjamin Peterson benjamin@python.org
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
(cherry picked from commit 40caa05)
Co-authored-by: Benjamin Peterson benjamin@python.org
Sorry, @benjaminp, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.cherry_picker 40caa05fa4d1810a1a6bfc34e0ec930c351089b7 2.7
benjaminp added a commit that referenced this pull request
benjaminp added a commit that referenced this pull request
(cherry picked from commit 40caa05)
Co-authored-by: Benjamin Peterson benjamin@python.org
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
(cherry picked from commit 40caa05)
Co-authored-by: Benjamin Peterson benjamin@python.org
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
(cherry picked from commit 40caa05)
Co-authored-by: Benjamin Peterson benjamin@python.org
| if test "$MACHDEP" = linux; then |
|---|
| undef HAVE_LCHMOD |
| if test "$MACHDEP" != linux; then |
| AC_CHECK_FUNC(lchmod) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you should drop lchmod from the call to AC_CHECK_FUNCS above...
miss-islington added a commit that referenced this pull request
(cherry picked from commit 40caa05)
Co-authored-by: Benjamin Peterson benjamin@python.org
miss-islington added a commit that referenced this pull request
(cherry picked from commit 40caa05)
Co-authored-by: Benjamin Peterson benjamin@python.org
It looks like this did not backport correctly to 2.7.x, because 2.7.16 (which lists this issue as being fixed) refuses to surface os.lchmod on OSX at all, whereas 2.7.15 surfaces it just fine (as expected on OSX). The absence of os.lchmod from 2.7.16 for MacOS is breaking scripts.