bpo-34784: Fix PyStructSequence_NewType by eduardo-elizondo · Pull Request #9524 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

eduardo-elizondo

PyStructSequence_NewType does not currently work. This aims to fix the implementation of PyStructSequence_NewType to fully create a heap allocated StructSequence.

In this change, I refactored some of the functionality of PyStructSequence_InitType2 into static functions so that it can be reused by PyStructSequence_NewType.

https://bugs.python.org/issue34784

@eduardo-elizondo

taleinat

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs tests!

(I'm aware of PR GH-9665, but this should have standalone tests for this specific issue.)

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@eduardo-elizondo

@taleinat I'm closing this change in favor of #9665. I have updated the other one to include tests!