gh-94808: Cover str.rsplit for UCS1, UCS2 or UCS4 by sobolevn · Pull Request #98228 · python/cpython (original) (raw)

This code was not covered:
Снимок экрана 2022-10-13 в 1 46 36

Now, it is!

@vstinner I got curious and looked into other asciilib_* calls. The setup is the same as in #98025 (comment)
For example, asciilib_rsplit_whitespace also does not give any significant gain:
./env/bin/python.exe -m pyperf timeit -v '"a b ca b d".rsplit()'

// With asciilib call:
// Mean +- std dev: 134 ns +- 4 ns
// Mean +- std dev: 143 ns +- 5 ns

// Without it:
// Mean +- std dev: 137 ns +- 2 ns
// Mean +- std dev: 140 ns +- 7 ns

I will open a new issue about where we can discuss this!