gh-94808: add tests covering PyFunction_{Get,Set}Closure by sobolevn · Pull Request #99429 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits4 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Comment on lines 6017 to 6018
| Py_INCREF(closure); |
|---|
| return closure; |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Py_INCREF(closure); |
|---|
| return closure; |
| return Py_NewRef(closure); |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has merge conflicts now.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
After a year, I took the liberty of updating to the current main branch, and fixed two nitpicks.
Sorry about that. Go ahead and merge!
@encukou thanks a lot for your help! I forgot about this PR a long time ago :)
No problem, happy to help :)
Usually we backport test changes to reduce future conflicts, but since this already causes conflicts in 3.12, I'll skip the backport here.
vstinner pushed a commit to vstinner/cpython that referenced this pull request
adorilson pushed a commit to adorilson/cpython that referenced this pull request
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request
