Allow inverting --local-partial-types by hauntsaninja · Pull Request #18377 · python/mypy (original) (raw)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making --local-partial-types invertible will certainly help which it's adoption. E.g. we could also consider adding it to --strict as a first step before making it the default in 2.0.
I do just wonder what change made the test diffs necessary. Adding add_invertible_flag with default=False shouldn't change anything, does it?
It will probably make sense to enable it for all our tests by default, but in that case the test config should probably be changed in the same PR. E.g. it could be added here.
| options = parse_options(original_program_text, testcase, incremental_step) |
|---|
| options.use_builtins_fixtures = True |
| options.show_traceback = True |
--
Feel free to split that up into a different PR if you like though.