PEP 740: Index support for digital attestations by woodruffw · Pull Request #3618 · python/peps (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation44 Commits18 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Signed-off-by: William Woodruff william@yossarian.net

Has this been discussed anywhere? Who is sponsoring this?

Cool, can you include that link in the PEP draft please? It might end up getting replaced at some point with a different link, but at least that'll give a bit of context to the draft.

Sure, no problem! I'm on mobile at the moment, but I'll update the draft once I'm in front of a computer. Apologies for any confusion I've caused 🙂

Sure, no problem! I'm on mobile at the moment, but I'll update the draft once I'm in front of a computer.

Yep, no rush, just trying to make sure everyone can see what's going on. Thanks!

Signed-off-by: William Woodruff william@yossarian.net

Co-authored-by: Hugo van Kemenade 1324225+hugovk@users.noreply.github.com

Signed-off-by: William Woodruff william@yossarian.net

I'll take a look through in a bit, but just to publicly record it, I'm fine sponsoring this and being the delegate for it (It's PyPI so I'm the default delegate anyways).

I've marked this as ready for review, now that it has a sponsor and PEP-Delegate (thank you @dstufft!)

Signed-off-by: William Woodruff william@yossarian.net

All commit authors signed the Contributor License Agreement.

hugovk changed the title~~Draft PEP: Index support for digital attestations~~ PEP 740: Index support for digital attestations

Jan 12, 2024

Co-authored-by: Hugo van Kemenade 1324225+hugovk@users.noreply.github.com

Signed-off-by: William Woodruff william@yossarian.net

Apparently the PEP index can't handle multiple emails for a single human name.

Signed-off-by: William Woodruff william@yossarian.net

For visibility, I had to revert my email address change because of this:

                                                                              
Extension error (pep_sphinx_extensions.pep_zero_generator.pep_index_generator)
:                                                                             
Handler <function create_pep_zero at 0x107615760> for event 'env-before-read-docs' threw an exception (exception: some authors have more than one email address listed:
    William Woodruff: {'william@trailofbits.com', 'william@yossarian.net'})
Command exited with exit code: 2

Yeah, that's a rather annoying restriction, maybe we should consider removing it? Another option is to also use your ToB email in the other PEPs if you prefer.

hugovk added the new-pep

A new draft PEP submitted for initial review

label

Jan 12, 2024

Yeah, removing it would be ideal (but I can imagine it might be non-trivial, if it's a restriction in the first place).

Using my personal email here is not a significant problem -- the ToB email would accurately reflect that this is for work rather than just funsies, but we have it tracked on our side anyways 🙂

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Here are some thoughts from me on this PEP:

Signed-off-by: William Woodruff william@yossarian.net

All feedback above is addressed/resolved, so I think approval/merge is next here (unless I've missed something) 🙂

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get the discussion rolling!

Labels

new-pep

A new draft PEP submitted for initial review