Switch to PEP 517 packaging using hatchling by akx · Pull Request #2930 · redis/redis-py (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation23 Commits8 Checks37 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Contributor
• Loading
Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.
Comparison is base (2f88840) 91.84% compared to head (835daaa) 91.84%.
Report is 5 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| redis/asyncio/connection.py | 83.33% | 1 Missing ⚠️ |
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@ ## master #2930 +/- ##
Coverage 91.84% 91.84% -0.01%
Files 128 127 -1
Lines 33232 33270 +38
- Hits 30523 30557 +34
- Misses 2709 2713 +4
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@akx Thanks for your contribution! I'll review this PR in near time
Contributor Author
akx commented
• Loading
@vladvildanov Rebased. I'll fix the tests if there's any interest in this.
This was referenced
Feb 20, 2025
Could you add "closes #3463 "?
Btw: the tests failing in
FAILED tests/test_asyncio/test_commands.py::TestRedisCommands::test_client_setinfo[single] - AssertionError: assert '5.3.0b5' == '5.2.1'
- 5.2.1
+ 5.3.0b5
is very curious – given the string "5.3.0b5" does not appear in the source here at all, it almost looks like the CI pipeline is installing an entirely different version of the package...
and indeed:
Downloading redis-5.3.0b5-py3-none-any.whl (271 kB)
IOW, the CI pipeline seems to be confused about which libraries it's using...
6 tasks
akx and others added 6 commits
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for getting this finally merged!
1 year, 5 months 3 weeks – could easily be a personal record for PR perseverance for me.
@akx Thanks for your efforts, I'm so sorry that It took so long from our side
6 tasks