Fix incorrect attribute reuse in redis.connection.CacheProxyConnection by zs-neo · Pull Request #3456 · redis/redis-py (original) (raw)

Pull Request check-list

Please make sure to review and check all of these items:

• Do tests and lints pass with this change?
• Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
• Is the new or changed code fully tested?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Is there an example added to the examples folder (if applicable)?
• Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Attemp to adress #3453

CacheProxyConnection adds caching capabilities to the send_command and read_response methods, but does not clear the _current_command_cache_key attribute. Pipeline and ClusterPipeline use send_packed_command to send requests, which may cause the wrong _current_command_cache_key to be reused during read_response.