TransactionStrategy reset: UNWATCH only when status is watching by tzongw · Pull Request #3671 · redis/redis-py (original) (raw)

Pull Request check-list

Please make sure to review and check all of these items:

• Do tests and lints pass with this change?
• Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
• Is the new or changed code fully tested?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

1749285597.757549 [0 127.0.0.1:49316] "WATCH" "key"
1749285597.758115 [0 127.0.0.1:49316] "GET" "key"
1749285597.758405 [0 127.0.0.1:49316] "MULTI"
1749285597.758422 [0 127.0.0.1:49316] "SET" "key" "value"
1749285597.758425 [0 127.0.0.1:49316] "EXEC"
1749285597.758929 [0 127.0.0.1:49316] "UNWATCH"

RedisCluster transaction always call UNWATCH in the end, this is not necessary mostly and adds a network round-trip time.
EXEC clears any watched keys.