Removing synchronous context manager handling from async RedisCluster. by petyaslavova · Pull Request #3679 · redis/redis-py (original) (raw)

Pull Request check-list

Please make sure to review and check all of these items:

• Do tests and lints pass with this change?
• Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
• Is the new or changed code fully tested?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Removing support for using AsyncRedisCluster as a synchronous context manager. This class is designed primarily for asynchronous usage, and the majority of its methods are async. Allowing it to be used in a synchronous context is misleading and could result in incorrect or unintended behavior.