Convert the value to int type only if it exists in CLIENT INFO by git-hulk · Pull Request #3688 · redis/redis-py (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits3 Checks36 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Pull Request check-list
Please make sure to review and check all of these items:
- Do tests and lints pass with this change?
- Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
- Is the new or changed code fully tested?
- Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
- Is there an example added to the examples folder (if applicable)?
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Currently, client info will try to convert the set of keys to the int type without checking if it exists or not. To keep compatibility with newer Redis servers or other Redis-compatible services, we could just convert it only if the key exists.
Currently, client info will try to convert the set of keys to the int type
without checking if it exists or not. For example, both argv-mem and tot-mem
are introduced in 6.2, and force converting an non-existent value might
cause an exception in older version. To keep the compatibility with the older/newer
Redis server, we could just convert it only if the key exists.
Hi @git-hulk, apologies for the delayed response. I rebased your PR and will merge it tomorrow.
@petyaslavova Thank you! I see one of CI is broke but it's related to upload the artifact and not relate to the current fix. Should I worry about this.
@petyaslavova Thank you! I see one of CI is broke but it's related to upload the artifact and not relate to the current fix. Should I worry about this.
@git-hulk No worries, it happens quite often lately. I restarted that job.
petyaslavova pushed a commit that referenced this pull request
Currently, client info will try to convert the set of keys to the int type
without checking if it exists or not. For example, both argv-mem and tot-mem
are introduced in 6.2, and force converting an non-existent value might
cause an exception in older or newer versions. To keep the compatibility with the older/newer
Redis server, we could just convert it only if the key exists.
Labels
2 participants
