Add redis 8.4-M01-pre to tested redis versions. by petyaslavova · Pull Request #3790 · redis/redis-py (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits5 Checks40 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Pull Request check-list
Please make sure to review and check all of these items:
- Do tests and lints pass with this change?
- Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
- Is the new or changed code fully tested?
- Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
- Is there an example added to the examples folder (if applicable)?
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here.
| fail-fast: false |
|---|
| matrix: |
| redis-version: ['8.2.1-pre', '${{ needs.redis_version.outputs.CURRENT }}', '8.0.2' ,'7.4.4', '7.2.9'] |
| redis-version: ['8.4-M01-pre', '${{ needs.redis_version.outputs.CURRENT }}', '8.0.2' ,'7.4.4', '7.2.9'] |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't change 8.2 to 8.4 and instead support both. 8.4 is another version to support so instead we have to remove 7.4 and 7.2 as soon as they EOL
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found that into the image version that is marked as CURRENT, once a patch is released, the base version image gets updated/rebuilt. For example, when 8.2.1 has been released, the 8.2 image gets rebuilt to contain Redis server with version 8.2.1. So now when 8.2.2 is release the used CURRENT(which is 8.2) will automatically start using it for the tests.
I was wondering if it is time to remove at least 7.2, but decided to add this removal in an additional PR after discussing this internally ...
…pipeline is not skipping a test
