don't remove m2w64_ prefix in stdlib piggyback by h-vetinari · Pull Request #2551 · regro/cf-scripts (original) (raw)

@h-vetinari

@h-vetinari

@h-vetinari

Currently this only considers {{ compiler("m2w64_c") }}, not other m2w64_* compilers. AFAICT that should be good enough though.

@codecov

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.88%. Comparing base (3e086ea) to head (1e9844e).

Additional details and impacted files

@@ Coverage Diff @@ ## master #2551 +/- ##

Coverage 69.88% 69.88%

Files 105 105
Lines 10597 10597

Hits 7406 7406
Misses 3191 3191

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

h-vetinari

@@ -178,8 +178,8 @@ def _process_section(output_index, attrs, lines):
if line_compiler_c and line_compiler_m2c:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't fire if a recipe only uses {{ compiler("m2w64_c") }} on windows and no other compilers elsewhere. If someone has a case of such a recipe, I can add it as a test and loosen the restriction here.

@beckermr

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})