add ims_article() by auzaheta · Pull Request #372 · rstudio/rticles (original) (raw)

Thanks for the contribution ! This is a really great first contribution to rticles !
Thanks a lot for having following closely the guide! This is working well and there are very few questions on my side.

First of all, I understand that the article is based on the template of AOAS journal. Do you think or know if this is generic to every journals they have ? I see several: https://www.e-publications.org/ims/support/ims-instructions.html and did not compare the templatex .tex

Does changing only the journal: aoas field in the YAML will work for any journal they have ?

I ask because usually the function is journalname_article(). So it seems it should be called aosas_article instead as this is the name of the journal. But if what I said before, maybe we could make an exception.

If not we could keep one function, but may need to modify a bit. Like providing an argument to the function ims_article(journal = "aoas) that would switch between the correct template for IMS and using the share component. If there is no shared component, then maybe it is one function in rticles by journal.

For the rest of the comments, see below. There is a few things that I think needs to change (depending on your feedback). For the rest this is mainly for discussion before merging.

For example ,I made some suggestion to include a bit less LaTeX syntax and use more markdown in the skeleton. Pandoc and rmarkdown allow to write some markdown syntax to generate the expected latex. What do you think ?